mps-youtube: 0.2.8 -> unstable-2020-01-28 #80269

k0ral · 2020-02-16T13:46:23Z

Motivation for this change

mps-youtube-0.2.8 is no longer compatible with the version of mpv included in nixpkgs (cf this issue).
There haven't been any mps-youtube release since then, so the only way to fix it is to point at a git revision.

Things done

pkgs/development/python-modules/mps-youtube/default.nix

jonringer

this commit is broken

$ ./results/python37Packages.mps-youtube/bin/mpsyt
could not load MPRIS interface. missing libraries.
Traceback (most recent call last):
  File "/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/bin/.mpsyt-wrapped", line 6, in <module>
    from mps_youtube import main
  File "/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/__init__.py", line 9, in <module>
    from . import main
  File "/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/main.py", line 30, in <module>
    from . import g, c, commands, screen, history, util
  File "/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/commands/__init__.py", line 5, in <module>
    from ..main import completer
ImportError: cannot import name 'completer' from 'mps_youtube.main' (/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/main.py)

[nix-shell:/nix/store/fiwc2apkmm7840d5vb2fmhh5lml2dhwy-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages]$ cd mps_youtube
__init__.py  c.py      commands   content.py       description_parser.py  helptext.py  init.py   main.py   paths.py   players      playlists.py  streams.py       util.py
__pycache__  cache.py  config.py  contentquery.py  g.py                   history.py   listview  mpris.py  player.py  playlist.py  screen.py     terminalsize.py

they reference a module that doesn't exist anymore

k0ral · 2020-02-16T17:55:24Z

Works on my side (it feels weird to say this when using NixOS):

$ grep completer /nix/store/d3yrji9kp1kn2jvnb056wlkz60k8503d-python3.7-mps-youtube-unstable-2020-01-28                                                                                Sun 16 Feb 2020 06:52:34 PM CET
/nix/store/d3yrji9kp1kn2jvnb056wlkz60k8503d-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/main.py
34:completer = None
39:    completer = util.CommandCompleter()
41:    readline.set_completer(completer.complete_command)
42:    readline.set_completer_delims('')

/nix/store/d3yrji9kp1kn2jvnb056wlkz60k8503d-python3.7-mps-youtube-unstable-2020-01-28/lib/python3.7/site-packages/mps_youtube/commands/__init__.py
5:from ..main import completer
28:        completer.add_cmd(command)

completer is well defined inside main module.

jonringer · 2020-02-16T23:43:09Z

is this supposed to be used as a standalone application? (like a cli utility?)

k0ral · 2020-02-17T06:29:04Z

Yes, this is a standalone CLI application.

jonringer · 2020-02-17T06:31:03Z

The reason why I ask is that we could export this as a top level mps-youtube command using buildPythonApplication, and not mess with package (which is much more fragile as to what environment is calling it)

k0ral · 2020-02-17T19:41:08Z

I've just replaced buildPythonPackage with buildPythonApplication, as suggested. Today I learned :) .

jonringer

Please move the expression out of python-modules and into an appropriate directory

pkgs/top-level/python-packages.nix

k0ral · 2020-02-18T06:32:58Z

Moved to pkgs/applications/misc, added deprecation notice in python-packages.

jonringer · 2020-02-18T06:45:10Z

would still like @FRidh to sign off

@worldofpeace do you have any strong feelings?

jonringer · 2020-02-18T06:45:26Z

LGTM, for what it's worth

FRidh · 2020-02-18T08:58:35Z

pkgs/top-level/all-packages.nix

@@ -20371,6 +20371,10 @@ in

  mpc-qt = libsForQt5.callPackage ../applications/video/mpc-qt { };

+  mps-youtube = callPackage ../applications/misc/mps-youtube {
+    pythonPackages = python3Packages;


remove the argument

FRidh · 2020-02-18T08:58:44Z

pkgs/applications/misc/mps-youtube/default.nix

-{ lib, buildPythonPackage, fetchFromGitHub, isPy3k
-, pafy
-}:
+{ lib, pythonPackages, fetchFromGitHub }:


use python3Packages here

worldofpeace · 2020-02-18T14:33:37Z

pkgs/top-level/python-packages.nix

@@ -6383,7 +6383,7 @@ in {

  maildir-deduplicate = callPackage ../development/python-modules/maildir-deduplicate { };

-  mps-youtube = callPackage ../development/python-modules/mps-youtube { };
+  mps-youtube = throw "mps-youtube has moved to all-packages, and is no longer available as a python module.";


would love to do this, but we really need an removed-python.nix.
I don't think this should be a throw though, mps-youtube and python3Packages.mps-youtube should be equivalent, and I have no reason to believe anyone used it as a module.

I would suggest the following

Suggested change

mps-youtube = throw "mps-youtube has moved to all-packages, and is no longer available as a python module.";

mps-youtube = pkgs.mps-youtube;

but we really shouldn't be having aliases in python-packages.nix, we'd have the same situation that created aliases.nix in the first place.

you would need to do something like mps-youtube = pkgs.mps-youtube.override { inherit python;}; otherwisei you'll get different interpreter versions.

Right, so no alias or warning at all. Maybe not the best UI, but easiest for Nixpkgs maintainers. I like that.

worldofpeace · 2020-02-18T14:35:28Z

@k0ral Your commit message has the wrong date 785fe19.
It should be 2020-01-28 not 2010

k0ral · 2020-02-18T20:01:05Z

Updated with all your comments taken into account.

jonringer

please squash commits, and just make a mention in the body that the package was moved from python-modules to all-packages :)

Also move derivation from python-packages to all-packages, as this is a standalone application.

k0ral · 2020-02-20T07:03:33Z

Squashed commits.

jonringer

LGTM
executable shows usage

[2 built, 7 copied (59.3 MiB), 16.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80269
1 package built:
mps-youtube

k0ral requested review from FRidh and jonringer as code owners February 16, 2020 13:46

ofborg bot added 6.topic: python 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 16, 2020

jonringer reviewed Feb 16, 2020

View reviewed changes

pkgs/development/python-modules/mps-youtube/default.nix Outdated Show resolved Hide resolved

k0ral force-pushed the nixos-unstable branch from 3ebdaf7 to 2b38a9f Compare February 16, 2020 17:08

k0ral changed the title ~~mps-youtube: 0.2.8 -> 2010-01-28~~ mps-youtube: 0.2.8 -> unstable-2010-01-28 Feb 16, 2020

k0ral force-pushed the nixos-unstable branch from 2b38a9f to 785fe19 Compare February 16, 2020 17:09

jonringer reviewed Feb 16, 2020

View reviewed changes

ofborg bot added 8.has: clean-up 8.has: package (new) labels Feb 17, 2020

jonringer reviewed Feb 18, 2020

View reviewed changes

pkgs/top-level/python-packages.nix Show resolved Hide resolved

k0ral force-pushed the nixos-unstable branch from edd5a51 to 4d0be84 Compare February 18, 2020 06:32

FRidh reviewed Feb 18, 2020

View reviewed changes

worldofpeace reviewed Feb 18, 2020

View reviewed changes

worldofpeace changed the title ~~mps-youtube: 0.2.8 -> unstable-2010-01-28~~ mps-youtube: 0.2.8 -> unstable-2020-01-28 Feb 18, 2020

k0ral force-pushed the nixos-unstable branch from 4d0be84 to 0358141 Compare February 18, 2020 20:00

jonringer reviewed Feb 20, 2020

View reviewed changes

mps-youtube: 0.2.8 -> unstable-2020-01-28

cc5ba54

Also move derivation from python-packages to all-packages, as this is a standalone application.

k0ral force-pushed the nixos-unstable branch from 0358141 to cc5ba54 Compare February 20, 2020 07:03

jonringer approved these changes Feb 20, 2020

View reviewed changes

jonringer merged commit d57c05a into NixOS:master Feb 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mps-youtube: 0.2.8 -> unstable-2020-01-28 #80269

mps-youtube: 0.2.8 -> unstable-2020-01-28 #80269

k0ral commented Feb 16, 2020

jonringer left a comment

k0ral commented Feb 16, 2020 •

edited

jonringer commented Feb 16, 2020

k0ral commented Feb 17, 2020 •

edited

jonringer commented Feb 17, 2020

k0ral commented Feb 17, 2020

jonringer left a comment

k0ral commented Feb 18, 2020

jonringer commented Feb 18, 2020

jonringer commented Feb 18, 2020

FRidh Feb 18, 2020

FRidh Feb 18, 2020

worldofpeace Feb 18, 2020

jonringer Feb 18, 2020

FRidh Feb 18, 2020

worldofpeace commented Feb 18, 2020

k0ral commented Feb 18, 2020

jonringer left a comment

k0ral commented Feb 20, 2020

jonringer left a comment

	mps-youtube = throw "mps-youtube has moved to all-packages, and is no longer available as a python module.";
	mps-youtube = pkgs.mps-youtube;

mps-youtube: 0.2.8 -> unstable-2020-01-28 #80269

mps-youtube: 0.2.8 -> unstable-2020-01-28 #80269

Conversation

k0ral commented Feb 16, 2020

Motivation for this change

Things done

jonringer left a comment

Choose a reason for hiding this comment

k0ral commented Feb 16, 2020 • edited

jonringer commented Feb 16, 2020

k0ral commented Feb 17, 2020 • edited

jonringer commented Feb 17, 2020

k0ral commented Feb 17, 2020

jonringer left a comment

Choose a reason for hiding this comment

k0ral commented Feb 18, 2020

jonringer commented Feb 18, 2020

jonringer commented Feb 18, 2020

FRidh Feb 18, 2020

Choose a reason for hiding this comment

FRidh Feb 18, 2020

Choose a reason for hiding this comment

worldofpeace Feb 18, 2020

Choose a reason for hiding this comment

jonringer Feb 18, 2020

Choose a reason for hiding this comment

FRidh Feb 18, 2020

Choose a reason for hiding this comment

worldofpeace commented Feb 18, 2020

k0ral commented Feb 18, 2020

jonringer left a comment

Choose a reason for hiding this comment

k0ral commented Feb 20, 2020

jonringer left a comment

Choose a reason for hiding this comment

k0ral commented Feb 16, 2020 •

edited

k0ral commented Feb 17, 2020 •

edited