Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove myself as maintainer. #80315

Closed
wants to merge 1 commit into from
Closed

Remove myself as maintainer. #80315

wants to merge 1 commit into from

Conversation

falsifian
Copy link
Contributor

I'm not really that familiar with these two packages.

(I plan to merge this myself.)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@falsifian
Remove myself as maintainer.
3d472b3 
I'm not really that familiar with these two packages.
@falsifian
Copy link
Contributor Author

Pushed directly, bypassing the pull request mechanism. (I opened a pull request because I thought maybe some automatic checks would run, but I didn't see any on this one.)

@falsifian falsifian closed this Feb 16, 2020
@falsifian falsifian deleted the rm_maint branch February 16, 2020 22:16
@grahamc
Copy link
Member

grahamc commented Feb 16, 2020

There are automatic checks, but the checker is delayed due to an influx of PRs. Please always wait for the green check from @ofborg.

@falsifian
Copy link
Contributor Author

Oops, thanks, I'll wait next time. I guess at this point it would probably complicate things more to reverse my push.

@grahamc
Copy link
Member

grahamc commented Feb 16, 2020

Yep, no worries on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@falsifian @grahamc