Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siji: split output into out, bdf, otb #80220

Merged
merged 1 commit into from Feb 17, 2020
Merged

siji: split output into out, bdf, otb #80220

merged 1 commit into from Feb 17, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 16, 2020

Motivation for this change

Issue #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested BDF and PCF font using xfd
  • Tested OTB in lemonbar-xft.
  • Tested compilation of all pkgs that depend on this change (siji)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .out outputs look very different:

[16:56:11] jon@jon-desktop /home/jon/projects/nixpkgs (bump-vector)
$ tree ./result
./result
└── share
    └── fonts
        ├── bdf
        │   └── siji.bdf
        └── pcf
            └── siji.pcf

PR:

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80220]$ tree ./results/siji
./results/siji
└── share
    └── fonts
        └── misc
            ├── fonts.dir
            └── siji.pcf.gz

3 directories, 2 files

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 16, 2020

the .out outputs look very different:

It's intended that way: the .otb fonts must be put in a separate output to avoid conflicts with .pcf ones. Also it makes more sense to split the .bdf fonts because they are larger and not strictly necessary given a .pcf (even compressed) already exists. Regarding the path, share/fonts/misc seems to be the standard location to install fonts.

@jonringer
Copy link
Contributor

I'm just concerned about people who may be using it currently, and made assumptions about the shape of the "out" derivation.

splitting it makes sense to me

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 16, 2020

I'm just concerned about people who may be using it currently, and made assumptions about the shape of the "out" derivation.

You are right, I've postponed these set of changes to after the feature freeze because it will be breaking to many and the have to be properly documented.

@rnhmjoj rnhmjoj merged commit 06d625a into NixOS:master Feb 17, 2020
@rnhmjoj rnhmjoj deleted the siji branch April 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants