Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: 5.7.1 -> 5.8 #80227

Merged
merged 1 commit into from Feb 21, 2020
Merged

zsh: 5.7.1 -> 5.8 #80227

merged 1 commit into from Feb 21, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 16, 2020

https://www.zsh.org/mla/zsh-announce/141

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pSub February 16, 2020 01:49
Valodim
Valodim approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. also checked the tomb depending package.

nix-review also built haskellPackages.hapistrano, but I couldn't figure out why? it doesn't seem to depend on zsh.

pkgs/shells/zsh/default.nix
};

patches = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marsam marsam merged commit c675a7e into NixOS:master Feb 21, 2020
@zowoq zowoq deleted the zsh branch February 21, 2020 10:37
@redvers redvers mentioned this pull request Nov 4, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim approved these changes

@doronbehar doronbehar doronbehar approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @Valodim @doronbehar @marsam