Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moolticute: 0.30.8 -> 0.42.32-testing #80222

Merged
merged 1 commit into from Feb 16, 2020
Merged

moolticute: 0.30.8 -> 0.42.32-testing #80222

merged 1 commit into from Feb 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 16, 2020 •
edited

Motivation for this change

closes #69670

the -testing variations appear to contain bug fixes according to their releases https://github.com/mooltipass/moolticute/releases

so i grabbed the latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danbst
danbst reviewed Feb 16, 2020
View reviewed changes
pkgs/applications/misc/moolticute/default.nix
}:

stdenv.mkDerivation rec {
mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have I missed something, is this new official mkDerivation style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for qt packages, yes. This mkDerivation is actually different than stdenv.mkDerivation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right! thanks. I wish it was called mkQtDerivation #65399 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as do i, it causes a lot of confusion. Or buildQtApplication

@danbst danbst merged commit 1df3c86 into NixOS:master Feb 16, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 16, 2020
@jonringer @dtzWill
moolticute: 0.30.8 -> 0.42.32-testing (NixOS#80222)
c8618a6 
(cherry picked from commit 1df3c86)
@jonringer jonringer deleted the bump-moolticute branch February 16, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst danbst left review comments

@kirikaza kirikaza Awaiting requested review from kirikaza

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @danbst