Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] go_1_13: 1.13.7 -> 1.13.8, go_1_12: 1.12.16 -> 1.12.17 (backport) #80278

Merged
merged 2 commits into from Mar 1, 2020
Merged

[19.09] go_1_13: 1.13.7 -> 1.13.8, go_1_12: 1.12.16 -> 1.12.17 (backport) #80278

merged 2 commits into from Mar 1, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 16, 2020 •
edited

Motivation for this change

https://github.com/golang/go/releases/tag/go1.12.17
https://github.com/golang/go/releases/tag/go1.13.8

Backport of #80165

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
go_1_12: 1.12.16 -> 1.12.17
bb95650 
(cherry picked from commit bca1fa2)
@Frostman
go_1_13: 1.13.7 -> 1.13.8
ac62b2d 
(cherry picked from commit f703142)
@Frostman
Copy link
Member Author

@GrahamcOfBorg build yq-go hugo restic

@Frostman
Copy link
Member Author

@FRidh could you probably merge it for 19.09 as well? Thanks

@worldofpeace worldofpeace merged commit 0252dfb into NixOS:release-19.09 Mar 1, 2020
@Frostman Frostman deleted the stable-go-bump branch March 1, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@velovix velovix Awaiting requested review from velovix

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @worldofpeace