wasm-gc: remove package #80237
Merged
wasm-gc: remove package #80237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream repository has been archived, with a note that this should never be needed: https://github.com/alexcrichton/wasm-gc It also happens to have custom patch logic that will fail the newer cargo verification in NixOS#79975
jonringer
approved these changes
Feb 16, 2020
|
@Ekleog what do you say? |
|
I kind of disagree with the argument that wasm-gc is now unnecessary (the rust compiler is not the only one), but my use case is indeed solved without it now, I don't know how many other users of it there are nowadays, and the repo is archived and thus officially unmaintained… so I'm totally ok with removing this from nixpkgs! |
Ekleog
approved these changes
Feb 16, 2020
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 16, 2020
wasm-gc: remove package (cherry picked from commit 9ad73df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream repository has been archived, with a note that this should never be needed:
https://github.com/alexcrichton/wasm-gc
It also happens to have custom patch logic that will fail the newer cargo
verification in #79975
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)