Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wishbone-utils: 0.2.8 -> 0.6.9 #80239

Merged
merged 1 commit into from Feb 16, 2020
Merged

wishbone-utils: 0.2.8 -> 0.6.9 #80239

merged 1 commit into from Feb 16, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 16, 2020

The upstream repository has moved its URL here:
https://github.com/xobs/wishbone-utils

This also contains some cleanup to make the cargo tarball checker find the cargo
lockfile in the source directory; see #79975 for details.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
wishbone-utils: 0.2.8 -> 0.6.9
ca43b13 
The upstreeam repository has moved its URL here:
https://github.com/xobs/wishbone-utils

This also contains some cleanup to make the cargo tarball checker find the cargo
lockfile in the source directory; see NixOS#79975 for details.
@bhipple bhipple requested a review from edef1c February 16, 2020 04:29
@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

@GrahamcOfBorg build wishbone-utils

@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

Not sure why OfBorg claims this doesn't exist. It built just fine for me.

jonringer
jonringer approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80239
1 package built:
wishbone-tool

@jonringer jonringer merged commit dc851d4 into NixOS:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@edef1c edef1c Awaiting requested review from edef1c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @jonringer