Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] brightnessctl: Add systemd support (backport) #80215

Merged
merged 2 commits into from Feb 18, 2020
Merged

[20.03] brightnessctl: Add systemd support (backport) #80215

merged 2 commits into from Feb 18, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 15, 2020

Motivation for this change

Backport of #79663. IMO it makes sense to backport this since 20.03 is still in the "alpha" stage, to have a consistent behavior on 20.03 and nixos-unstable, and as I already updated the Wiki page: https://nixos.wiki/wiki/Backlight#brightnessctl. But if anyone has objections we can close this, it's completely optional (both methods work).

cc @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
brightnessctl: Add systemd support
9229fae 
This makes it possible to use brightnessctl without udev rules / suid.

(cherry picked from commit cf5dd26)
@primeos
nixos/brightnessctl: Remove the module
e8042ed 
Due to the support of the systemd-logind API the udev rules aren't
required anymore which renders this module useless [0].
Note: brightnessctl should now require a working D-Bus setup and a valid
local logind session for this to work.

[0]: NixOS#79663

(cherry picked from commit 5282bc9)
@ofborg ofborg bot requested a review from megheaiulian February 16, 2020 00:19
@flokli
Copy link
Contributor

flokli commented Feb 16, 2020

I think that's fine, but let's ping @NixOS/backports for the final decision ;-)

worldofpeace
worldofpeace approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically a change that would cause a users configuration to fail to build in the stable release and require migration steps isn't the best. But it actually seems mostly harmless, but me investigating into dbus stuff in NixOS #79663 (comment) could be concerning.

It's still a 👍 though.

@flokli flokli merged commit 8c96485 into NixOS:release-20.03 Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @flokli @megheaiulian @worldofpeace