Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: disable test ipc_closed_handle #80341

Closed
wants to merge 1 commit into from
Closed

libuv: disable test ipc_closed_handle #80341

wants to merge 1 commit into from

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Disabling unstable test case in libuv: it often times out, depending on infrastructure.
See libuv/libuv#2307 for further information

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Feb 17, 2020
Closed
Closed
Closed
Closed
@ofborg ofborg bot requested a review from cstrahan February 17, 2020 09:23
@veprbl
Copy link
Member

veprbl commented Feb 17, 2020

This doesn't fail on Hydra and it's a mass-rebuild, so, please, target staging branch instead of master.

@FRidh FRidh added this to WIP in Staging via automation Feb 17, 2020
Staging automation moved this from WIP to Done Feb 21, 2020
@vcunat
Copy link
Member

vcunat commented Feb 21, 2020

🤔 this actually seems interesting: libuv/libuv#2679 – perhaps it would allow us to enable many of the tests in nixpkgs again, though that doesn't seem an important aim to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnoldfarkas @veprbl @vcunat