Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.arch: init at 4.11 #80343

Closed
wants to merge 3 commits into from
Closed

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Packaging Python module 'arch' 4.11 in Nix, and also its missing dependency, namely 'property-cached' 1.6.3.
Please note that test case ipc_closed_handle of libuv is unstable, the relevant change is also submitted as a separate PR (#80341).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -19,6 +19,7 @@ stdenv.mkDerivation rec {
"threadpool_multiple_event_loops" # times out on slow machines
"get_passwd" # passed on NixOS but failed on other Linuxes
"tcp_writealot" # times out sometimes
"ipc_closed_handle" # times out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this causes a lot of rebuilds... 5000+

@FRidh
Copy link
Member

FRidh commented Feb 27, 2020

please get rid of these mass-rebuilding commits in PR's that don't need it.

@FRidh FRidh closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants