pythonPackages.pydruid: init at 0.5.8 #80345
Conversation
| sha256 = "0zb6zmklib26fzv5dvqzy0h0p1ljjgkklnjm66imc35mx5irpzcv"; | ||
| }; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
default patchPhase does a lot of things for you
| patchPhase = '' | |
| postPatch = '' |
There was a problem hiding this comment.
I see, I should change other commits, since I used patchPhase instead of postPatch.
Will do it.
| def expected_results_csv_reader():" | ||
| ''; | ||
|
|
||
| propagatedBuildInputs = [ pandas prompt_toolkit pycurl pygments requests six sqlalchemy tabulate tornado ]; |
There was a problem hiding this comment.
really long, please list, please make into single item lines
| propagatedBuildInputs = [ pandas prompt_toolkit pycurl pygments requests six sqlalchemy tabulate tornado ]; | |
| propagatedBuildInputs = [ | |
| pandas | |
| prompt_toolkit | |
| ... | |
| ]; |
There was a problem hiding this comment.
sure, is there a limit somewhere? (it fits to half screen for me so, below 120 characters - what is the standard max line width before wrapping?)
There was a problem hiding this comment.
not really, but generally I do a max of ~3. Just helps with quickly digesting the expression
|
please get rid of these mass-rebuilding commits in PR's that don't need it. |
| @@ -19,6 +19,7 @@ stdenv.mkDerivation rec { | |||
| "threadpool_multiple_event_loops" # times out on slow machines | |||
| "get_passwd" # passed on NixOS but failed on other Linuxes | |||
| "tcp_writealot" # times out sometimes | |||
| "ipc_closed_handle" # times out | |||
There was a problem hiding this comment.
| "ipc_closed_handle" # times out |
avoid mass rebuild
|
Motivation for this change
Packaging Python module 'pydruid' 0.5.8 in Nix, and a fix for unstable test in libuv (which is also submitted as a separate PR: #80341)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)