Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cvxpy: init at 1.0.25 (and its dependencies) #80342

Closed
wants to merge 5 commits into from
Closed

pythonPackages.cvxpy: init at 1.0.25 (and its dependencies) #80342

wants to merge 5 commits into from

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Packaging Python module 'cvxpy' 1.0.25 in Nix, and its missing dependencies: 'ecos-python' 2.0.7.post1, 'osqp-python' 0.6.1 and 'scs-python' 2.1.1-2.
Please note that test case ipc_closed_handle in libuv times out, disabling that test is submitted as a separate PR as well: #80341.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cstrahan and dotlambda February 17, 2020 09:35
@drewrisinger
Copy link
Contributor

Possible duplicate of #78898 ?
Most of the sub-dependencies have been moved in-tree at this point.

@jonringer
Copy link
Contributor

superseded by #78898

@jonringer jonringer closed this Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@cstrahan cstrahan Awaiting requested review from cstrahan

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnoldfarkas @drewrisinger @jonringer