treewide: batched rust cargoSha256 upgrades #80265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
Infra upgrade as part of NixOS#79975; no functional change expected.
|
Eh, not a big fan of this approach; aside from it going into conflict (which it now has), and causing a lot of rebuilds all at once for something that's fine being an incremental gradual upgrade, there's a bystander effect on testing/approving/merging when it's a big pile of packages. I think I'll stick to individual PRs that are more digestible, unless you prefer otherwise @jonringer. |
|
individual is fine by me. It does make the build times a lot shorter plus, rustc take an ungodly amount of RAM to build stuff. I go from ~2Gb used, to 30Gb+ used when kicking off many rust projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This batches together a handful of relatively straightforward upgrades. Since
there's a lot of compilation and fixed-output merge conflict risk, I think this
is too big to build and test in one huge treewide PR, but also want to be
conscientious about not spamming the PR inbox for NixPkgs by sending them all
1-by-1. Let me know what you'd prefer.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)