Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iosevka: don't show build progress #80335

Merged
merged 1 commit into from Feb 17, 2020
Merged

iosevka: don't show build progress #80335

merged 1 commit into from Feb 17, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 17, 2020

Motivation for this change

The node progress "bar" looks like crap when using nix-build. Redirect
the infinite scrolling screen to /dev/null to calm the output down.
Errors will still print because stderr isn't redirected.

("infinite scrolling" is hyperbole)

NOTE: This really only applies when custom-building Iosevka, because
otherwise it gets fetched from the cache. Still extremely annoying when
you have a private build plan like I do.

Comparison

with node spam (imagine this happening for minutes at a time):
image

without node spam (nice and calm!):
image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The node progress "bar" looks like crap when using `nix-build`. Redirect
the infinite scrolling screen to `/dev/null` to calm the output down.
Errors will still print because stderr isn't redirected.
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great 👍

@rnhmjoj rnhmjoj merged commit 0240b3c into NixOS:master Feb 17, 2020
@cole-h cole-h deleted the iosevka branch February 17, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants