Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] firefox 73 #80327

Merged
merged 7 commits into from Feb 18, 2020
Merged

[19.09] firefox 73 #80327

merged 7 commits into from Feb 18, 2020

Conversation

andir
Copy link
Member

@andir andir commented Feb 17, 2020

Motivation for this change

This is the long overdue backport of #79786 to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
rust_1_41: init at 1.41.0
d06ec64 
This is a backport to be able to build firefox 73.0 on nixos-19.09.
@andir
rust-cbindgen_0_1_13: init at 0.1.13
884967c
@andir
nss_3_49_2: init at 3.49.2
7420ce3
@andir
firefox: prepare for 73.0
dfa2bb0 
(cherry picked from commit 187d691)
@andir
firefox: 72.0.2 -> 73.0
f814b79 
(cherry picked from commit 8019df9)
@andir
firefox-esr: 68.4.2esr -> 68.5.0esr
4e62685 
(cherry picked from commit f43fdd1)
@andir
firefox-bin: 72.0.3 -> 73.0
1e8947c 
(cherry picked from commit 1192073)
@andir andir requested a review from taku0 February 17, 2020 01:37
@vcunat
Copy link
Member

vcunat commented Feb 17, 2020

Duplicate of #80119, I suppose?

@andir
Copy link
Member Author

andir commented Feb 17, 2020

Except that it compiles and actually works :-)

@andir
Copy link
Member Author

andir commented Feb 18, 2020

I did another compilation run on another machine and that also looks good. If there are no objections I'll merge this in ~6h.

@mweinelt
Copy link
Member

mweinelt commented Feb 18, 2020 •
edited 

$ nix-review pr 80327 --build-args "--option builders ''"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs release-19.09:refs/nixpkgs-review/0 pull/80327/head:refs/nixpkgs-review/1
$ git worktree add /home/hexa/.cache/nixpkgs-review/pr-80327-3/nixpkgs 847bf0b8f1702bcdf4f8197e0d18ea75b8d70409
Preparing worktree (detached HEAD 847bf0b8f17)
HEAD is now at 847bf0b8f17 postgresql_11: 11.5 -> 11.7
$ git merge --no-commit 1e8947c11dcda4e0ce560b3090609f7dbcf658ab
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/hexa/.cache/nixpkgs-review/pr-80327-3/build.nix --option builders 
[23 built]
https://github.com/NixOS/nixpkgs/pull/80327
1 package marked as broken and skipped:
conkeror-unwrapped

13 package built:
adoptopenjdk-icedtea-web cargo_1_41 dropbox dropbox-cli firefox-bin-unwrapped firefox-esr-68-unwrapped xulrunner mate.caja-dropbox mozplugger nss_3_49_2 rust-cbindgen_0_1_13 rustc_1_41 slimerjs

lgtm

@taku0
Copy link
Contributor

taku0 commented Feb 18, 2020

firefox-bin and firefox are fine. firefox-esr is being built.

@andir andir merged commit bdc9e2b into NixOS:release-19.09 Feb 18, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/firefox-not-up-to-date/5941/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 Awaiting requested review from taku0

@wizeman wizeman Awaiting requested review from wizeman

@jtojnar jtojnar Awaiting requested review from jtojnar

@globin globin Awaiting requested review from globin

@cstrahan cstrahan Awaiting requested review from cstrahan

@madjar madjar Awaiting requested review from madjar

@edolstra edolstra Awaiting requested review from edolstra

@retrry retrry Awaiting requested review from retrry

Assignees
No one assigned
Labels
6.topic: rust 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andir @vcunat @mweinelt @taku0 @nixos-discourse