New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacsPackages.org-roam: init at 0.1.2 #80280
Conversation
Could you try to get upstream to upload the package to elpa/melpa? |
Sure. Asked for that in org-roam/org-roam#171 |
I'd like to upload to MELPA when things become more stable, which is when I decide it's version |
A melpa release won't happen any time soon. The question is, do we want org-roam in nixpkgs now, or should I stash it in my overlay? I would go for nixpkgs as org-roam is quite an active project and gets excellent traction (see pulse). I've been using 0.1.2 for two weeks now, and I find it quite stable and useful. @adisbladis, what do you think? |
Within the next week I think! |
oh wow. that's great news! I think we should wait then :) |
Great! I was just going to say "let's just add it", but if a proper MELPA release is coming soon then let's wait for it :) |
:fetcher github | ||
:files ("*.el")) | ||
''; | ||
packageRequires = [ dash f s async ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for when 1.0.0 lands:
packageRequires = [ dash f s async ]; | |
packageRequires = [ dash f s emacsql emacsql-sqlite ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jethrokuan If the package is pulled from melpa all those bit's are automagic.
I'm closing this for now since the package will arrive in Nixpkgs through the usual MELPA workflow. |
Can we now install org-roam from our NixOS configuration? I've tried the obvious way, by adding
Two of you have made public your NixOS configurations; I cloned them and grepped (case insensitive) for Here's the commit where I made the change, and here's the complete file including that change. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
It's in FWIW, here is the relevant part of my config: README.org:671 |
I tried putting it under melpa instead of melpaStable. I even tried under elpa. They all give me the same error, except with a different line number. It's as if Nix is looking at an old Melpa repo when it tries to build my config. Your config includes So I tried adding the overlay you mentioned. First time overlaying, and I don't know if I added it the right way. How I added the overlay didn't generate an error but neither did it solve this problem. I tried to understand your .org file that turns into your .nix files. Oh my god, I haven't felt so stupid in years; I don't even know what I would have to study to understand it. When I run |
The thing is you are explicitly passing What you should be doing is adding the overlay to the NixOS option |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/my-first-overlay-for-emacs/7570/1 |
Thanks! I thought that might be happening, but it was the only thing I tried that compiled. I had looked at the section of the emacs-overlay README you mention, and also the NixOS wiki article on overlays, and was totally baffled. I just started a new thread on the NixOS Discourse to tackle that problem. |
Motivation for this change
org-roam seems to be a nice package, but it's not packaged into melpa/elpa
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I'm running it now and it works fine.