citra: update to 2020-03-28 #83758
citra: update to 2020-03-28 #83758
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/138 |
There was a problem hiding this comment.
This need to be wrapped with wrapQtAppsHook. See this issue for details #65399
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
|
I would suggest to go ahead with the update as it doesn't make the situation worse than before. I would open a new PR to fix the wrapping issue then. Please confirm if you would be ok with doing it like this. |
|
I will try to use wrapQtAppsHook. Sorry for not having noticied the older PR. Will commit once it finish compiling. |
|
I added wrapQtAppsHook in nativeBuildInputs, and I didn't see any difference. So I'm totally ok to let @petabyteboy do what he need with this, and accept this PR as is. |
|
PR #83193 fixes the issue with Qt and appears to have been well tested. The fact it's building a slightly older revision is probably not important, so unless you are against I'm going to merge that one. |
|
I'm totally okay about you merging the older update @rnhmjoj (this revision also have the function I'm looking for). |
|
Thank you, I merged the other PR an will do a backport soon. |
Motivation for this change
A recent update to citra added some interesing functionallity for rom-hacking (dynamic patch to the game file system)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Checked it work with some game and homebrew, including testing the specific part I need.