Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citra: update to 2020-03-28 #83758

Closed
wants to merge 1 commit into from
Closed

citra: update to 2020-03-28 #83758

wants to merge 1 commit into from

Conversation

marius851000
Copy link
Contributor

Motivation for this change

A recent update to citra added some interesing functionallity for rom-hacking (dynamic patch to the game file system)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Checked it work with some game and homebrew, including testing the specific part I need.

@ofborg ofborg bot requested a review from abbradar March 30, 2020 09:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/138

rnhmjoj
rnhmjoj requested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be wrapped with wrapQtAppsHook. See this issue for details #65399

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

@rnhmjoj rnhmjoj mentioned this pull request Apr 9, 2020
Merged
10 tasks
@ghost
Copy link

ghost commented Apr 9, 2020 •
edited by ghost

I would suggest to go ahead with the update as it doesn't make the situation worse than before. I would open a new PR to fix the wrapping issue then. Please confirm if you would be ok with doing it like this.

@marius851000
Copy link
Contributor Author

I will try to use wrapQtAppsHook. Sorry for not having noticied the older PR. Will commit once it finish compiling.

@marius851000
Copy link
Contributor Author

I added wrapQtAppsHook in nativeBuildInputs, and I didn't see any difference. So I'm totally ok to let @petabyteboy do what he need with this, and accept this PR as is.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 10, 2020

PR #83193 fixes the issue with Qt and appears to have been well tested. The fact it's building a slightly older revision is probably not important, so unless you are against I'm going to merge that one.

@marius851000
Copy link
Contributor Author

I'm totally okay about you merging the older update @rnhmjoj (this revision also have the function I'm looking for).

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 10, 2020

Thank you, I merged the other PR an will do a backport soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj requested changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marius851000 @nixos-discourse @rnhmjoj