New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session-desktop: init at 1.0.8 #83698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and starts correctly on NixOS unstable.
Any update here? |
What needs to be done for this to be merged? |
This is functional and ready to merge, although I am personally not satisfied with using a pre-built AppImage. |
@mehlon Are you willing to add yourself as the maintainer of this? |
meta = with lib; { | ||
description = "Desktop client for Session Messenger"; | ||
homepage = https://getsession.org/; | ||
license = licenses.gpl3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plus or Only?
description = "Desktop client for Session Messenger"; | ||
homepage = https://getsession.org/; | ||
license = licenses.gpl3; | ||
#maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add yourself as a maintainers.
Sorry, I won't be maintaining this package. |
Adding packages without any maintainer basically marks them to be eventually broken. Maybe we shouldn't add the package if no one is planning to maintain it. |
Yes, we can't accept this without a maintainer. If someone wants to pick that up, we can reopen. |
Motivation for this change
Fixes #81927
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)