Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session-desktop: init at 1.0.8 #83698

Closed
wants to merge 4 commits into from
Closed

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Mar 29, 2020

Motivation for this change

Fixes #81927

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts correctly on NixOS unstable.

@mehlon mehlon changed the title session-desktop: init at 1.0.5 session-desktop: init at 1.0.6 Apr 14, 2020
@mehlon mehlon changed the title session-desktop: init at 1.0.6 session-desktop: init at 1.0.7 Apr 22, 2020
@mehlon mehlon changed the title session-desktop: init at 1.0.7 session-desktop: init at 1.0.8 May 16, 2020
@LEXUGE
Copy link
Contributor

LEXUGE commented Jun 10, 2020

Any update here?

@billksun
Copy link
Contributor

billksun commented Jul 1, 2020

What needs to be done for this to be merged?

@mehlon
Copy link
Contributor Author

mehlon commented Jul 1, 2020

This is functional and ready to merge, although I am personally not satisfied with using a pre-built AppImage.
I would prefer to build it from source, but I have not felt the need for this software, so I haven't worked on it.

@ryantm
Copy link
Member

ryantm commented Sep 23, 2020

@mehlon Are you willing to add yourself as the maintainer of this?

meta = with lib; {
description = "Desktop client for Session Messenger";
homepage = https://getsession.org/;
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus or Only?

description = "Desktop client for Session Messenger";
homepage = https://getsession.org/;
license = licenses.gpl3;
#maintainers = with maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself as a maintainers.

@mehlon
Copy link
Contributor Author

mehlon commented Jan 20, 2021

Sorry, I won't be maintaining this package.

@SuperSandro2000
Copy link
Member

Sorry, I won't be maintaining this package.

Adding packages without any maintainer basically marks them to be eventually broken. Maybe we shouldn't add the package if no one is planning to maintain it.

@ryantm
Copy link
Member

ryantm commented Jan 21, 2021

Yes, we can't accept this without a maintainer. If someone wants to pick that up, we can reopen.

@ryantm ryantm closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Session Messenger
6 participants