ghc-8.4.4.nix: Do not use git.haskell.org #83697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which was deprecated in 2018 and is now gone for good. I guess many won’t notice because the nix-cache kept the files around? This fetches the patches from github. Unfortunately it seems that the sha256 hashes (calculated with `nix-prefetch-url`) have been modified. Alternatively, if someone has the old patches around they could arguably be added to `tarballs.nixos.org` (it seems they are not there right now).
|
@shlevy I see you included some patches there located on |
|
@GrahamcOfBorg build haskell.compiler.ghc844 |
|
@GrahamcOfBorg build haskell.compiler.ghc844 |
|
@nomeata Looks good to me, thanks for fixing this! |
nomeata
added a commit
to dfinity/ic-hs
that referenced
this pull request
May 11, 2021
by pulling in NixOS/nixpkgs#83697 which may of course break any number of other things Originally dfinity/interface-spec@a0ba975
nomeata
added a commit
to dfinity/ic-hs
that referenced
this pull request
May 11, 2021
by pulling in NixOS/nixpkgs#83697 which may of course break any number of other things Originally https://github.com/dfinity-lab/ic-ref/commit/a0ba97557557298ccd61b76977cfa5145d33d771
nomeata
added a commit
to dfinity/ic-hs
that referenced
this pull request
May 11, 2021
by pulling in NixOS/nixpkgs#83697 which may of course break any number of other things Originally https://github.com/dfinity-lab/ic-ref/commit/a0ba97557557298ccd61b76977cfa5145d33d771
nomeata
added a commit
to dfinity/ic-hs
that referenced
this pull request
May 25, 2021
by pulling in NixOS/nixpkgs#83697 which may of course break any number of other things Originally https://github.com/dfinity-lab/ic-ref/commit/a0ba97557557298ccd61b76977cfa5145d33d771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which was deprecated in 2018 and is now gone for good. I guess many
won’t notice because the nix-cache kept the files around?
This fetches the patches from github. Unfortunately it seems that the
sha256 hashes (calculated with
nix-prefetch-url) have been modified.Alternatively, if someone has the old patches around they could arguably
be added to
tarballs.nixos.org(it seems they are not there rightnow).