ofborg: pass rev #442
Merged
ofborg: pass rev #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydra seems to have passed in rev all the time, and nixpkgs will soon require `rev` to be set. This initially broke nixpkgs eval in NixOS/nixpkgs@5e8545e, so we now update ofborg to always pass `rev` when instantiating nixpkgs to avoid breaking it.
Here, we can easily access the real commit ID, so pass it in instead of a bogus rev and shortRev. Hydra seems to have passed in rev all the time, and nixpkgs will soon require `rev` to be set. This initially broke nixpkgs eval in NixOS/nixpkgs@5e8545e, so we now update ofborg to always pass `rev` when instantiating nixpkgs to avoid breaking it.
grahamc
reviewed
Mar 30, 2020
| "{{ outPath=./.; revCount=999999; shortRev=\"{}\"; rev=\"{}\"; }}", | ||
| &self.job.pr.head_sha[0..7], | ||
| &self.job.pr.head_sha, | ||
| ); |
There was a problem hiding this comment.
wow you're getting fancy here with the head_sha stuff :P
There was a problem hiding this comment.
Well, at least here it's easy to get it, so we can very well pass in the proper value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydra seems to have passed in rev all the time, and nixpkgs will soon
require
revto be set.This initially broke nixpkgs eval in
NixOS/nixpkgs@5e8545e,
so we now update ofborg to always pass
revwhen instantiating nixpkgsto avoid breaking it.