Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/magic-wormhole-mailbox-server: init #83768

Merged
merged 2 commits into from Mar 31, 2020
Merged

nixos/magic-wormhole-mailbox-server: init #83768

merged 2 commits into from Mar 31, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Mar 30, 2020 •
edited

Motivation for this change

Adding this pretty simple service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from infinisil as a code owner March 30, 2020 11:30
@mmahut
Copy link
Member Author

mmahut commented Mar 30, 2020

@GrahamcOfBorg test magic-wormhole-mailbox-server

@mmahut mmahut force-pushed the magic-wormhole-mailbox-server branch from 299b1a1 to af75bb1 Compare March 30, 2020 14:15
@mmahut
Copy link
Member Author

mmahut commented Mar 30, 2020

@GrahamcOfBorg test magic-wormhole-mailbox-server

@mmahut
Copy link
Member Author

mmahut commented Mar 30, 2020

@GrahamcOfBorg eval

1000101
1000101 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • ran nix-review without any failures
  • ran and tested the binaries

@tfc tfc self-requested a review March 31, 2020 11:14
@mmahut mmahut merged commit 63f3adf into NixOS:master Mar 31, 2020
lukateras
lukateras reviewed Mar 31, 2020
View reviewed changes
nixos/modules/module-list.nix
@@ -394,6 +394,7 @@
./services/mail/mailcatcher.nix
./services/mail/mailhog.nix
./services/mail/mailman.nix
./services/mail/magic-wormhole-mailbox-server.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: it's not mail ^^ Probably would be best under ./services/servers. See: https://magic-wormhole.readthedocs.io/en/latest/welcome.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, not even sure why I put it there, brainfart. Quickfix: #83876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras left review comments

@tfc tfc tfc approved these changes

@1000101 1000101 1000101 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmahut @tfc @1000101 @lukateras