Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.pandoc-crossref: fix build and more #83810

Merged
merged 2 commits into from Mar 31, 2020
Merged

haskellPackages.pandoc-crossref: fix build and more #83810

merged 2 commits into from Mar 31, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 30, 2020

Motivation for this change

pandoc-crossref managed to break in both 20.03 and unstable but I need it badly.

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested by building a pandoc document
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from infinisil as a code owner March 30, 2020 21:06
cdepillabout
cdepillabout requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one comment above, this looks good.

Feel free to go ahead and merge in when the comment above has been addressed.

@rnhmjoj rnhmjoj merged commit 01b7fcb into NixOS:haskell-updates Mar 31, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 31, 2020

@cdepillabout Do you have any information about the LTS update in 20.03? I delayed a fix for pandoc-crossref in 20.03 because the upcoming update (and this PR at this point) would have fixed it.

@cdepillabout
Copy link
Member

@rnhmjoj At one point, I was under the impression that @peti was going to do the update to LTS-15 in 20.03, but then I feel like I saw something saying he decided not to do it.

@peti, are you still planning on updating 20.03 to LTS-15, or is that no longer planned?

@rnhmjoj rnhmjoj deleted the haskell-updates branch April 7, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

@peti peti Awaiting requested review from peti

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @cdepillabout