Skip to content

futhark: build and install manpages #83716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

futhark: build and install manpages #83716

merged 1 commit into from
Mar 30, 2020
+28 −11

Conversation

athas
Copy link
Contributor

@athas athas commented Mar 29, 2020

Motivation for this change

The futhark package used to not install man pages. Now it does. The only complication is that the futhark source tarball contains only manpage sources (in RST format), which must be built using Sphinx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

cdepillabout
cdepillabout requested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments above with small changes to make, although I haven't actually tested that they work. If you merge them in, please test that they all actually do what they appear to do.

Also, please rebase this on the haskell-updates branch and set the base branch to haskell-updates here on github.

@athas athas changed the base branch from master to haskell-updates March 30, 2020 06:08
@athas athas force-pushed the futhark-manpage branch from 3773f56 to f8fdf1f Compare March 30, 2020 06:19
@athas
Copy link
Contributor Author

athas commented Mar 30, 2020

Alright, I made the changes, rebased on haskell-updates, and it still builds fine. Looks like changing the base branch on GitHub made poor ofborg think this is a much bigger deal than it really is, though.

@cdepillabout
Copy link
Member

Looks good, and builds on linux, so I'll go ahead and merge this in.

Thanks for fixing this up!

@cdepillabout cdepillabout merged commit 4b76133 into NixOS:haskell-updates Mar 30, 2020
@athas athas deleted the futhark-manpage branch March 30, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@athas @cdepillabout