Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: 14.2.7 -> 14.2.8 #83749

Merged
merged 2 commits into from Apr 6, 2020
Merged

ceph: 14.2.7 -> 14.2.8 #83749

merged 2 commits into from Apr 6, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 30, 2020 •
edited

Motivation for this change

Regular update.

WIP until dashboard is tested, it looks like the patch may no longer be necessary, but needs verification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from johanot, krav and adevress March 30, 2020 05:10
@srhb srhb requested review from lejonet and removed request for krav, tfc, andir, adevress, FRidh, jonringer and infinisil April 2, 2020 19:12
@ofborg ofborg bot added the 6.topic: nixos label Apr 2, 2020
@ofborg ofborg bot requested review from krav and adevress April 2, 2020 19:19
@srhb
Copy link
Contributor Author

srhb commented Apr 2, 2020

Had to poke the tests for the new pg must be powers of two-warning.
Looks like this might be our last master-version of 14.x, Octopus is out.

@srhb
Copy link
Contributor Author

srhb commented Apr 3, 2020

Confirmed, dashboard is good. Finally rid of that patch. O:-)

@srhb srhb changed the title WIP: ceph: 14.2.7 -> 14.2.8 ceph: 14.2.7 -> 14.2.8 Apr 3, 2020
lejonet
lejonet approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@lejonet lejonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly ran both tests on my system and they checked out and I can't see anything obviously wonky with the PR. Its a "standard" minor version bump, with the added benefit that we could get rid of a unnecessarily blunt patch.

@srhb srhb merged commit b256b22 into NixOS:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lejonet lejonet lejonet approved these changes

@johanot johanot Awaiting requested review from johanot

@krav krav Awaiting requested review from krav

@adevress adevress Awaiting requested review from adevress

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @lejonet