pythonPackages.pyarrow: remove dead code in preCheck, use pytestCheckHook #83747
+5
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python27Packages.pyarrow |
ofborg
bot
added
6.topic: python
11.by: package-maintainer
bhipple
approved these changes
Mar 30, 2020
tobim
approved these changes
Mar 30, 2020
jonringer
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
LGTM
failures are broken on master
https://github.com/NixOS/nixpkgs/pull/83747
2 packages failed to build:
python37Packages.ibis-framework python38Packages.ibis-framework
14 packages built:
python27Packages.awkward python27Packages.pyarrow python27Packages.uproot python27Packages.uproot-methods python37Packages.awkward python37Packages.google_cloud_bigquery python37Packages.pyarrow python37Packages.uproot python37Packages.uproot-methods python38Packages.awkward python38Packages.google_cloud_bigquery python38Packages.pyarrow python38Packages.uproot python38Packages.uproot-methods
[1 built (2 failed), 0.0 MiB DL]
error: build of '/nix/store/4dkgniwjcingq3pl2dwbzyxcvz8nv6gq-python3.7-ibis-framework-1.2.0.drv', '/nix/store/bvxl4cbsd1n4mahba5ji5cjpcn7s2vq2-python3.8-ibis-framework-1.2.0.drv' failed
[17:49:07] jon@jon-desktop /home/jon/projects/nixpkgs (master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)