Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.docker: use dontUseSetuptoolsCheck #83748

Merged
merged 1 commit into from Apr 5, 2020
Merged

pythonPackages.docker: use dontUseSetuptoolsCheck #83748

merged 1 commit into from Apr 5, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 30, 2020

Motivation for this change

Noticed one odd use of doCheck while grepping for setuptoolsCheckPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Mar 30, 2020

@GrahamcOfBorg build python27Packages.docker
@GrahamcOfBorg build python37Packages.docker
@GrahamcOfBorg build python38Packages.docker

drewrisinger
drewrisinger approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Looks like builds via borg.

@veprbl veprbl merged commit f601ab3 into NixOS:master Apr 5, 2020
@veprbl veprbl deleted the pr/python_docker_dontUseSetuptoolsCheck branch December 1, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @drewrisinger