buildFHSChrootEnv: link gsettings-schemas to FHS location #83705
Conversation
|
@hedning I found a use for your code ✨ |
|
@worldofpeace awesome! Can you add a line somewhere in |
Didn't know there was docs. Will do. |
|
btw, I checked if anything using |
We shouldn't need to use wrapGAppsHook in expressions that use this builder. The code to do this is from NixOS#54083.
worldofpeace
force-pushed
the
fhs-gsettings
branch
from
2a30294
to
35faf0a
Compare
|
Meh, this isn't right. I will finish this tomorrow. |
|
Maybe here? |
I believe the appimage build support code, at its lowest level, uses this builder. |
|
Missing schemas also crash riot-desktop(electron), its not oly isolated to ssb-patchwork. |
riot-desktop doesn't use this builder at all, and I've already fixed that fe6addb |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/declarative-wrappers-another-idea/6661/1 |
|
heya folks - awesome work :) Is there something more we need to do to get this one merged ? :) |
| if [[ -d $out/share/gsettings-schemas/ ]]; then | ||
| # Create the standard schemas directory if needed | ||
| if [[ -L $out/share/glib-2.0 ]]; then | ||
| rm -rf $out/share/glib-2.0 |
There was a problem hiding this comment.
I am still not totally comfortable with removing the link. At the moment, I cannot think of a case where it would be destructive but conditions change.
Could we try to make the tree writeable like lndir does?
There was a problem hiding this comment.
@jtojnar could you point me to the lndir package you're referring to?
There was a problem hiding this comment.
I meant the lndir program, not the expression.
|
May I mention (in case it may help anybody) that i just tried running ssb-patchwork from the nix-shell ran by nixpkgs-review for this PR and ssb-patchwork crashed just the same when trying to choose an avatar. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Still relevant to me. |
stale
bot
removed
the
2.status: stale
We shouldn't need to use wrapGAppsHook in expressions
that use this builder. The code to do this is from #54083.
Motivation for this change
#83410 ssb-patchwork should now work without any wrapping.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)