Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.subunit: fix build and add tests #83813

Merged
merged 1 commit into from Mar 30, 2020
Merged

python3Packages.subunit: fix build and add tests #83813

merged 1 commit into from Mar 30, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 30, 2020 •
edited

Motivation for this change

noticed it was broken

did a fair amount of clean up as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner March 30, 2020 22:00
@jonringer
Copy link
Contributor Author

there were all previously broken:

https://github.com/NixOS/nixpkgs/pull/83813
13 package marked as broken and skipped:
python27Packages.jenkinsapi python27Packages.pyunbound python27Packages.suds python27Packages.zerobin python37Packages.jenkinsapi python37Packages.mozcrash python37Packages.mozdevice python37Packages.pyunbound python38Packages.jenkinsapi python38Packages.mozcrash python38Packages.mozdevice python38Packages.pyalgotrade python38Packages.pyunbound

2 package failed to build:
ape python37Packages.sunpy

56 package built:
buildbot buildbot-full buildbot-ui home-assistant home-assistant-cli jenkins-job-builder lexicon python27Packages.favicon python27Packages.fitbit python27Packages.geoip2 python27Packages.jenkins-job-builder python27Packages.mox3 python27Packages.packet-python python27Packages.python-jenkins python27Packages.requests-mock python27Packages.rxv python27Packages.sopel python27Packages.sqlalchemy_migrate python27Packages.subunit python27Packages.testrepository python27Packages.zeep python37Packages.denonavr python37Packages.favicon python37Packages.fitbit python37Packages.geoip2 python37Packages.mox3 python37Packages.packet-python python37Packages.pyairvisual python37Packages.python-jenkins python37Packages.requests-mock python37Packages.rxv python37Packages.sopel python37Packages.sqlalchemy_migrate python37Packages.subunit python37Packages.testrepository python37Packages.zeep python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.denonavr python38Packages.favicon python38Packages.fitbit python38Packages.geoip2 python38Packages.jenkins-job-builder python38Packages.mox3 python38Packages.packet-python python38Packages.pyairvisual python38Packages.python-jenkins python38Packages.requests-mock python38Packages.rxv python38Packages.sopel python38Packages.sqlalchemy_migrate python38Packages.subunit python38Packages.testrepository pytrainer streamlink

going to merge in 24hrs if there's no objections

@jonringer
Copy link
Contributor Author

I've seen this failing in many reviews, going merge for now

@jonringer jonringer merged commit 915d58b into NixOS:master Mar 30, 2020
@jonringer jonringer deleted the fix-subunit branch March 30, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @orivej