Feature/xonotic module #83761
Closed
Feature/xonotic module #83761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has many advantages: - Each variant can be installed without pulling in the dependencies of the other variants, which makes it possible to build an SDL variant without X11 dependencies - Hydra can now build binaries without downloading 1GB of data, so users do not have to build them on their own machines - Users do not have to redownload 1GB of data after each dependency update Includes the following fixes: - Add dependency on libGL for GLX variant as it will fail in some environments otherwise - Pass -j and -l to make to enable parallel building - Quote homepage URI and use https - Add a .desktop file and icons
ghost
suggested changes
Mar 30, 2020
| enable = mkEnableOption "Xonotic servers"; | ||
|
|
||
| servers = mkOption { | ||
| type = types.loaOf serverModule; |
| servers = mkOption { | ||
| type = types.loaOf serverModule; | ||
| default = {}; | ||
| description = "available serves"; |
| }; | ||
|
|
||
| preStart = let | ||
| configFile = pkgs.writeText "server.cfg" '' |
| in { | ||
| options = { | ||
| services.xonotic = { | ||
| enable = mkEnableOption "Xonotic servers"; |
There was a problem hiding this comment.
Can't you just check if cfg.servers != {}?
| }; | ||
|
|
||
| port = mkOption { | ||
| type = types.ints.u16; |
| default = 26000; | ||
| }; | ||
|
|
||
| options = mkOption { |
|
Created a new xonotic module. will maybe upstream it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
provide xonotic as a module to host servers. This module is designed to host more than one server
Things done
create a xonotic service
This PR is dependet on #83461 for the usage of the xonotic-dedicated package
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)