Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matomo: 3.13.3 -> 3.13.4 #83760

Merged
merged 1 commit into from Apr 2, 2020
Merged

matomo: 3.13.3 -> 3.13.4 #83760

merged 1 commit into from Apr 2, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Mar 30, 2020

Updated both matomo and matomo-beta to the latest version

Motivation for this change

this should, hopefully, be the last release of the 3.* series. after this it's on to the big four point oh. it contains security updates so recommend backporting. https://matomo.org/changelog/matomo-3-13-4/

Things done

Updated, tested install, ran tests, updated my server from my branch

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse @florianjacob

@Kiwi
matomo: 3.13.3 -> 3.13.4
761b391 
Updated both matomo and matomo-beta to the latest version
@florianjacob
Copy link
Contributor

@GrahamcOfBorg test matomo matomo-beta

@ofborg ofborg bot requested a review from florianjacob March 30, 2020 09:26
@aanderse
Copy link
Member

aanderse commented Apr 2, 2020

I'm going to mention again how weird it is that we have 2 different packages using the same version. If I didn't have a mountain of other priorities I would probably make a PR to remove the -beta.

Merging entirely based on the approval of @florianjacob as maintainer 🎉

@aanderse aanderse merged commit f71c9e8 into NixOS:master Apr 2, 2020
@Kiwi Kiwi deleted the matomo-3.13.4 branch August 19, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianjacob florianjacob florianjacob approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kiwi @florianjacob @aanderse