Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marktext: 0.16.0-rc.2 -> 0.16.1 #83701

Merged
merged 2 commits into from Jul 7, 2020
Merged

marktext: 0.16.0-rc.2 -> 0.16.1 #83701

merged 2 commits into from Jul 7, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 29, 2020

Motivation for this change

Changelog: https://github.com/marktext/marktext/blob/v0.16.1/.github/CHANGELOG.md#0161

Follow-up to #77694.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from dtzWill March 29, 2020 17:19
@nh2 nh2 self-assigned this Mar 29, 2020
@nh2
Copy link
Contributor Author

nh2 commented Mar 29, 2020

Builds on and runs on my machine.

Opening the file open dialog crashes it for me with

(marktext:21502): GLib-GIO-ERROR **: 19:13:11.316: Settings schema 'org.gtk.Settings.FileChooser' does not contain a key named 'show-type-column'

but that also happens on the current version (when I on my 19.09 machine start the same marktext version from nixpkgs master) so I suspect that just happens when trying to run master things on my 19.09.

@srhb
Copy link
Contributor

srhb commented Apr 2, 2020

On my 20.03, this crashes with:

(marktext:45852): GLib-GIO-ERROR **: 20:36:48.243: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

But maybe that's just a normal impurity?

nh2 added 2 commits July 6, 2020 22:58
@nh2
marktext: 0.16.0-rc.2 -> 0.16.1.
42a7167 
The upgrade apparently made it necessary to also add `XDG_DATA_DIRS`
to fix the crash mentioned in the added comment.

I copied this solution from:
`pkgs/applications/misc/devdocs-desktop/default.nix`
@nh2
marktext: 0.16.1 -> 0.16.2
8da4950
@nh2
Copy link
Contributor Author

nh2 commented Jul 6, 2020

On my 20.03, this crashes with

Same on Ubuntu now.

I found the solution:

   profile = ''
     export LC_ALL=C.UTF-8
+  ''
+  # Fixes file open dialog error
+  #     GLib-GIO-ERROR **: 20:36:48.243: No GSettings schemas are installed on the system
+  # See https://github.com/NixOS/nixpkgs/pull/83701#issuecomment-608034097
+  + ''
+    export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS
   '';

I copied this solution from:

nixpkgs/pkgs/applications/misc/devdocs-desktop/default.nix

Line 21 in d986fcc

export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS
after googling around and then searching for git grep -C 1000 XDG_DATA_DIRS pkgs/ | grep -i appimage in nixpkgs.

I've also upgraded to the latest point release.

@srhb please retest :)

@srhb
Copy link
Contributor

srhb commented Jul 7, 2020

Looks good!

@srhb srhb merged commit 7ae0fa1 into NixOS:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees

@nh2 nh2

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @srhb