libsignal-protocol-c: 2.3.2 -> 2.3.3 #83736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
requested changes
Apr 10, 2020
There was a problem hiding this comment.
regression in dino
builder for '/nix/store/va1zd7662idn8fp8z5yjl8wpry93lisc-dino-0.1.0.drv' failed with exit code 1; last 10 log lines:
required is exact version "2.3.2" (found
/nix/store/jfzmm0xzrbd2agq1f3r4a71s3hg84bi7-libsignal-protocol-c-2.3.3/lib/libsignal-protocol-c.so)
Call Stack (most recent call first):
/nix/store/cmriqbxnpcgmbll06pnl1h3va08x2xvr-cmake-3.16.5/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
cmake/FindSignalProtocol.cmake:9 (find_package_handle_standard_args)
plugins/signal-protocol/CMakeLists.txt:35 (find_package)
-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
cannot build derivation '/nix/store/2798y07hqqykqnw38dkzfilxjnyq8cg0-env.drv': 1 dependencies couldn't be built
[4 built (1 failed), 13 copied (46.3 MiB), 20.9 MiB DL]
error: build of '/nix/store/2798y07hqqykqnw38dkzfilxjnyq8cg0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83736
1 package failed to build:
dino
3 packages built:
libsignal-protocol-c profanity psi-plus
10 tasks
Luflosi
added a commit
to Luflosi/nixpkgs
that referenced
this pull request
May 9, 2020
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in NixOS#83736. Upstream already allows newer versions in the latest git master, so patch the source with this commit. Unfortunately patching doesn't work with git submodules but since the submodule is not used anyways, simply ignore this part of the patch.
ryantm
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsignal-protocol-c/versions.
meta.description for libsignal-protocol-c is: "Signal Protocol C Library"
meta.homepage for libsignal-protocol-c is: "https://github.com/signalapp/libsignal-protocol-c"
Updates performed:
Compare changes on GitHub
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
directory tree listing: https://gist.github.com/0237db4407430ef024db3b49179e29ba
du listing: https://gist.github.com/48699344dd7233ec7edc8b14648c4c62
Rebuild report (if merged into master) (click to expand)
14 total rebuild path(s)
4 package rebuild(s)
4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
dino
libsignal-protocol-c
profanity
psi-plus
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @orivej for testing.