Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xow: init at 0.4 #83732

Merged
merged 2 commits into from
Mar 31, 2020
Merged

xow: init at 0.4 #83732

merged 2 commits into from
Mar 31, 2020
+73 −0

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Mar 30, 2020

Motivation for this change

Taking over from #76185 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jansol jansol requested a review from infinisil as a code owner March 30, 2020 01:10
@jansol
Copy link
Contributor Author

jansol commented Mar 30, 2020

The bindir in the service file still seems wrong to me? It should probably be based on the same DESTDIR as everything else.

@jansol jansol mentioned this pull request Mar 30, 2020
Closed
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Mar 30, 2020
@ofborg ofborg bot requested a review from pmiddend March 30, 2020 01:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 30, 2020
jtojnar
jtojnar reviewed Mar 30, 2020
View reviewed changes
@jansol jansol changed the title xow: init at 0.3 xow: init at 0.4 Mar 30, 2020
@jansol
Copy link
Contributor Author

jansol commented Mar 30, 2020

Oh and @pmiddend do you want me to remove you from xow maintainers? Or are you fine with leaving that as is.

@pmiddend
Copy link
Contributor

Oh and @pmiddend do you want me to remove you from xow maintainers? Or are you fine with leaving that as is.

I think I'd be more comfortable not maintaining this.

Thanks again for your efforts!

@jtojnar jtojnar merged commit 0cb43d3 into NixOS:master Mar 31, 2020
@jtojnar
Copy link
Member

jtojnar commented Mar 31, 2020

Thank you both for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@infinisil infinisil

@pmiddend pmiddend

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jansol @pmiddend @jtojnar