Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.4.1 -> 0.4.2 #83719

Merged
merged 1 commit into from Mar 29, 2020
Merged

alacritty: 0.4.1 -> 0.4.2 #83719

merged 1 commit into from Mar 29, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Mar 29, 2020

  • alacritty now has its own org, so I changed the URLs to point there
  • updated the description to match upstream's description
  • formatted with nixpkgs-format
Motivation for this change

If the nixpkgs-format change is undesirable, I can undo it. Just let me know :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
alacritty: 0.4.1 -> 0.4.2
45f53cc 
* alacritty now has its own org, so I changed the URLs to point there
* updated the description to match upstream's description
* formatted with nixpkgs-format
@ofborg ofborg bot requested review from Mic92 and Br1ght0ne March 29, 2020 22:32
bhipple
bhipple approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 83719 1

1 package built: - alacritty

@bhipple bhipple merged commit 40fab12 into NixOS:master Mar 29, 2020
@cole-h cole-h deleted the alacritty branch March 29, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @bhipple