Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jadx: init at 1.1.0 #83745

Merged
merged 1 commit into from May 11, 2020
Merged

jadx: init at 1.1.0 #83745

merged 1 commit into from May 11, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 30, 2020

Motivation for this change

jadx is one of the most well known tools for Android reverse engineering.

It's slightly annoying to package due to the use of Gradle. Most of the Gradle stuff in this package expression is copy-pasted from other Gradle users in nixpkgs (jd-gui mostly).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 31, 2020

cc @artemist who authored #58232

@veprbl veprbl merged commit 6bcb1de into NixOS:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants