Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: add test mariadb with tokudb plugin #83765

Merged
merged 2 commits into from Mar 31, 2020
Merged

nixos/mysql: add test mariadb with tokudb plugin #83765

merged 2 commits into from Mar 31, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 30, 2020

Motivation for this change

Add test mariadb with tokudb plugin

cc @flokli @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Mar 31, 2020 •
edited

Tested locally, works. Thanks!

@flokli flokli merged commit a3d67bf into NixOS:master Mar 31, 2020
@Izorkin Izorkin deleted the mariadb-test branch March 31, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @flokli