Skip to content

Add menu options for line styles / view / configuration #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2020
Merged

Add menu options for line styles / view / configuration #575

merged 4 commits into from
Apr 1, 2020
+25 −0

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Mar 29, 2020

This is to make them a bit easier to find, since the natural place to look for config options is somewhere like File->Preferences or Edit->Settings. On Mac the Configuration should be under the "App" menu but I'm not sure how to do that.

@Timmmm
Add menu options for line styles / view / configuration
674c217 
This is to make them a bit easier to find, since the natural place to look for config options is somewhere like File->Preferences or Edit->Settings. On Mac the Configuration should be under the "App" menu but I'm not sure how to do that.
@whitequark
Copy link
Contributor

On Mac the Configuration should be under the "App" menu but I'm not sure how to do that.

It should already be there, as a special case I added in the platform code. Have you checked it?

whitequark
whitequark reviewed Mar 29, 2020
View reviewed changes
whitequark
whitequark reviewed Mar 29, 2020
View reviewed changes
whitequark
whitequark suggested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition overall. One thing I'm not sure about is handling it on Apple platforms. At least you should #ifdef away the Configuration item, but maybe all three would be more appropriate.

@Timmmm
Copy link
Contributor Author

Timmmm commented Apr 1, 2020

It should already be there, as a special case I added in the platform code. Have you checked it?

Ah no I haven't. Don't have it running on my Mac at the moment.

At least you should #ifdef away the Configuration item, but maybe all three would be more appropriate.

Opted for just the configuration item so there is still a way to get to the other two from menus on Mac. Hope that's ok!

@whitequark
Copy link
Contributor

Opted for just the configuration item so there is still a way to get to the other two from menus on Mac.

Seems OK to me, but I'm not sure what the macOS interface guidelines say about it. Regardless this is not a blocker for merging.

@whitequark whitequark merged commit 72635df into solvespace:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timmmm @whitequark