Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: 1.9.21 -> 2.0.1 #83790

Merged
merged 2 commits into from Apr 1, 2020
Merged

tdesktop: 1.9.21 -> 2.0.1 #83790

merged 2 commits into from Apr 1, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 30, 2020 •
edited

Motivation for this change

It was usable without any issues so far, but unfortunately there seem to be a few regressions behind the scene. At least some errors are printed to the console.

X11:

error: : cannot open
error: : cannot open
error: : cannot open

Wayland (unfortunately it deterministically segfaults after exiting):

error: : cannot open
error: : cannot open
error: : cannot open
Using the 'xdg-shell' shell integration
Segmentation fault (core dumped)

It's also possible that the first launch on Wayland always results in a frozen telegram-desktop, but at least it works after closing the window and launching it again...

Strace reveals the following:

14322 statx(26, "", AT_STATX_SYNC_AS_STAT|AT_EMPTY_PATH, STATX_ALL,  <unfinished ...>
14316 openat(AT_FDCWD, ".hz", O_RDONLY <unfinished ...>
14338 access("/nix/store/kp60cyq5iig35gzp7l2pr0ilxxa4m919-bash-interactive-4.4-p23/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14321 <... statx resumed>{stx_mask=STATX_ALL, stx_attributes=0, stx_mode=S_IFREG|0644, stx_size=4868, ...}) = 0
14316 <... openat resumed>)             = -1 ENOENT (No such file or directory)
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
14322 <... statx resumed>{stx_mask=STATX_ALL, stx_attributes=0, stx_mode=S_IFREG|0644, stx_size=51588, ...}) = 0
14316 write(2, "error: : cannot open\n", 21 <unfinished ...>
14338 access("/nix/store/mwfy3ihfydvrjmsimbd2kkr20n9abqsv-patchelf-0.9/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14321 lseek(25, 4, SEEK_SET <unfinished ...>
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
14322 lseek(26, 4, SEEK_SET <unfinished ...>
14316 <... write resumed>)              = 21
14321 <... lseek resumed>)              = 4
14322 <... lseek resumed>)              = 4
14316 openat(AT_FDCWD, "", O_RDONLY <unfinished ...>
14321 read(25,  <unfinished ...>
14316 <... openat resumed>)             = -1 ENOENT (No such file or directory)
14338 access("/nix/store/1wb31gzrjw055xl6d3igzj1gnajzlwbk-gcc-wrapper-9.2.0/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14316 openat(AT_FDCWD, ".hz", O_RDONLY <unfinished ...>
14321 <... read resumed>"\315r-\202\330\206f&\352\367\215\2\20\307\373\263r\223o\324\225\257GL\311n\35\373,sw\212"..., 16384) = 4864
14316 <... openat resumed>)             = -1 ENOENT (No such file or directory)
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
14316 write(2, "error: : cannot open\n", 21 <unfinished ...>
14321 read(25,  <unfinished ...>
14316 <... write resumed>)              = 21
14338 access("/nix/store/gh9a48qcwzw588vy4w72w93kad0mhhi8-gcc-9.2.0/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14321 <... read resumed>"", 11520)      = 0
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
14321 statx(25, "", AT_STATX_SYNC_AS_STAT|AT_EMPTY_PATH, STATX_ALL,  <unfinished ...>
14338 access("/nix/store/c2lx3lsqp0y5kwvwkqma8iihc7xjj1m8-glibc-2.30-bin/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14316 openat(AT_FDCWD, "", O_RDONLY <unfinished ...>
14321 <... statx resumed>{stx_mask=STATX_ALL, stx_attributes=0, stx_mode=S_IFREG|0644, stx_size=4868, ...}) = 0
14316 <... openat resumed>)             = -1 ENOENT (No such file or directory)
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
14316 openat(AT_FDCWD, ".hz", O_RDONLY <unfinished ...>
14321 futex(0x357d674, FUTEX_WAKE_PRIVATE, 1 <unfinished ...>
14316 <... openat resumed>)             = -1 ENOENT (No such file or directory)
14338 access("/nix/store/hzvl3dvv8651iqlb5g6gq5hzjzmhjn7m-coreutils-8.31/lib/qt-5.12.7/plugins/bearer/.", F_OK <unfinished ...>
14321 <... futex resumed>)              = 1
14320 <... futex resumed>)              = 0
14316 write(2, "error: : cannot open\n", 21 <unfinished ...>
14338 <... access resumed>)             = -1 ENOENT (No such file or directory)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar March 30, 2020 17:03
doronbehar
doronbehar approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tdesktop user here - builds and runs fine for me.

@anpryl
Copy link
Contributor

anpryl commented Apr 1, 2020 •
edited

There is already 2.0.1 release. https://github.com/telegramdesktop/tdesktop/releases/tag/v2.0.1
@primeos can you please update PR to a newer version?

@LEXUGE
Copy link
Contributor

LEXUGE commented Apr 1, 2020

tested on xorg without any problem.

@doronbehar
Copy link
Contributor

@primeos Maybe squash it to a single commit? Also - the PR's title..

@oxalica
Copy link
Contributor

oxalica commented Apr 1, 2020

Version 2.0.1 works well on xorg but still produces three lines of error: : cannot open in stdout after entering my local password.

@doronbehar
Copy link
Contributor

I got these error: : cannot open errors on Xorg and AwesomeWM with 2.0.0.

@primeos primeos changed the title tdesktop: 1.9.21 -> 2.0.0 tdesktop: 1.9.21 -> 2.0.1 Apr 1, 2020
@primeos
Copy link
Member Author

primeos commented Apr 1, 2020

Sorry for my delayed response, I was a bit low on time.

Thanks for the testing and feedback :)

The Wayland support is unfortunately degrading, but it should still be usable enough and there where also similar problems in the past - I guess it should be ok for now, but I've opened telegramdesktop/tdesktop#7547 to at least document these regressions.

@primeos primeos merged commit 606baf0 into NixOS:master Apr 1, 2020
grahamc pushed a commit that referenced this pull request Jul 8, 2020
@primeos @flokli
tdesktop: 1.9.21 -> 2.0.1 (#83790)
4b210eb 
* tdesktop: 1.9.21 -> 2.0.0
* tdesktop: 2.0.0 -> 2.0.1

(cherry picked from commit 606baf0)
github-actions bot added a commit to pbogdan/nix-hie that referenced this pull request Jul 10, 2020
@github-actions
niv stable: update c9d124e3 -> 6a00eba0
bf59209 
## Motivation

Dependencies should be up to date.

## Changelog for stable:
Commits: [NixOS/nixpkgs@c9d124e3...6a00eba0](NixOS/nixpkgs@c9d124e...6a00eba)

* [`6f7e39c7`](NixOS/nixpkgs@6f7e39c) setupcfg2nix: Bump to 2.0.1.
* [`a47a25d1`](NixOS/nixpkgs@a47a25d) nixos/plasma5: Noto Mono -> Noto Sans Mono
* [`7fb99d67`](NixOS/nixpkgs@7fb99d6) (rustup): (add zlib to rpath in rustup libraries)
* [`39f0831d`](NixOS/nixpkgs@39f0831) typora: 0.9.73 -> 0.9.89
* [`6be38862`](NixOS/nixpkgs@6be3886) gitlab: 12.10.13 -> 12.10.14
* [`1f0e4434`](NixOS/nixpkgs@1f0e443) pantheon.wingpanel-indicator-datetime: drop downstream patch
* [`c90edd39`](NixOS/nixpkgs@c90edd3) pantheon.elementary-session-settings: 5.0.3 -> 2019-11-12
* [`68264dc2`](NixOS/nixpkgs@68264dc) pantheon.elementary-session-settings: add g-s-d version mappings
* [`1919b1f3`](NixOS/nixpkgs@1919b1f) pantheon.wingpanel-indicator-datetime: 2.2.2 -> 2.2.4
* [`d622da56`](NixOS/nixpkgs@d622da5) pantheon.elementary-session-settings:  2019-11-12 -> 2020-06-11
* [`e2a3caa6`](NixOS/nixpkgs@e2a3caa) pantheon.elementary-calendar: 5.0.5 -> 5.0.6
* [`d7511a68`](NixOS/nixpkgs@d7511a6) pantheon.elementary-videos: 2.7.1 -> 2.7.2
* [`93a3d2f1`](NixOS/nixpkgs@93a3d2f) pantheon.wingpanel: 2.3.1 -> 2.3.2
* [`3e465751`](NixOS/nixpkgs@3e46575) nixos/pantheon: update greeter whitelist to new wording
* [`59d798ec`](NixOS/nixpkgs@59d798e) pantheon.wingpanel-indicator-datetime: 2.2.4 -> 2.2.5
* [`fdd81551`](NixOS/nixpkgs@fdd8155) pantheon.granite: 5.4.0 -> 5.5.0
* [`d5a4a823`](NixOS/nixpkgs@d5a4a82) pantheon.pantheon-agent-polkit: 1.0.2 -> 1.0.3
* [`579cdb89`](NixOS/nixpkgs@579cdb8) pantheon.elementary-dock: 2020-02-28 -> 2020-06-11
* [`abd69cc1`](NixOS/nixpkgs@abd69cc) tl-expected: init at 2019-11-11
* [`6a322515`](NixOS/nixpkgs@6a32251) tdesktop: 1.9.9 -> 1.9.12
* [`46c4d885`](NixOS/nixpkgs@46c4d88) tdesktop: 1.9.12 -> 1.9.13
* [`1cad1b18`](NixOS/nixpkgs@1cad1b1) tdesktop: 1.9.13 -> 1.9.14
* [`a666ff9a`](NixOS/nixpkgs@a666ff9) tdesktop: 1.9.14 -> 1.9.21 (NixOS/nixpkgs#82806)
* [`4b210ebb`](NixOS/nixpkgs@4b210eb) tdesktop: 1.9.21 -> 2.0.1 (NixOS/nixpkgs#83790)
* [`5d68f77c`](NixOS/nixpkgs@5d68f77) tdesktop: 2.0.1 -> 2.1.0
* [`6a00eba0`](NixOS/nixpkgs@6a00eba) libvirtd: don't start libvirtd-tcp.socket by default
@github-actions github-actions bot mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@primeos @anpryl @LEXUGE @doronbehar @oxalica