Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi-calc: init at 1.6 #83136

Merged
merged 4 commits into from Mar 29, 2020
Merged

rofi-calc: init at 1.6 #83136

merged 4 commits into from Mar 29, 2020

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented Mar 22, 2020 •
edited

Motivation for this change

Add the rofi-calc plugin and add a way to add rofi plugins in a pure way as well.
Also adding @albakham as a maintainer since he's interested in helping to keep it up to date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@luc65r luc65r mentioned this pull request Mar 22, 2020
Closed
@luc65r
Copy link
Contributor Author

luc65r commented Mar 22, 2020

related PR: nix-community/home-manager#1109

@wamserma
Copy link
Member

@luc65r you might want to cherry-pick e1efcdf here or move it to an individual PR

Ma27
Ma27 requested changes Mar 22, 2020
View reviewed changes
pkgs/applications/science/math/rofi-calc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/rofi/wrapper.nix Outdated Show resolved Hide resolved
@luc65r luc65r force-pushed the pkg/rofi-calc branch 2 times, most recently from 483bc01 to bc15bde Compare March 23, 2020 16:33
@garbas garbas merged commit 8edd400 into NixOS:master Mar 29, 2020
@cole-h cole-h mentioned this pull request Mar 30, 2020
Merged
10 tasks
@luc65r luc65r deleted the pkg/rofi-calc branch April 25, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee left review comments

@teto teto teto left review comments

@wamserma wamserma wamserma requested changes

@Ma27 Ma27 Ma27 requested changes

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@luc65r @wamserma @garbas @rycee @teto @Ma27 @mkg20001