Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out fetcher of Maven dependencies #83725

Closed
wants to merge 1 commit into from
Closed

Factor out fetcher of Maven dependencies #83725

wants to merge 1 commit into from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 29, 2020

Currently there are 4 slowly-diverging copies. Also added limit on number of retries.

Tested gephi, exhibitor & global-platform-pro on my machine, hadoop is still building.

cc @volth @Radvendii @Ekleog @joelthompson

Motivation for this change

Was considering using the same approach for building jitsi-videobridge and jicofo, which would increase the number of copies to 6. The retry limit was added after staring at infinitely looping failing build for too long.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ekleog and Radvendii March 29, 2020 23:51
@mmilata
Factor out fetcher of Maven dependencies
13d1bae 
Currently there are 4 slowly-diverging copies.

Added limit on number of retries.
@mmilata mmilata force-pushed the factor-out-fetch-maven-deps branch from 288f61b to 13d1bae Compare March 30, 2020 01:09
@mmilata
Copy link
Member Author

mmilata commented Mar 30, 2020 •
edited

@volth

  1. I'm aware, unfortunately it's the only method I could use to build the application, had no luck with mvn2nix nor mavenix. In fact the dependencies change daily so it doesn't make sense to submit these packages to nixpkgs. Except for hadoop all sha256s match btw.
  2. Removed.

Agreed that this method is bad, however there's lack of alternatives. Perhaps we can name the function something like impureFetchMavenDeps to indicate that? I won't mind dropping this PR though.

mmilata added a commit to otevrenamesta/nur-packages that referenced this pull request Mar 30, 2020
@mmilata
lib: fetchMavenDeps
3245dac 
NixOS/nixpkgs#83725
@Mic92
Copy link
Member

Mic92 commented Mar 30, 2020

Could we not have a script that takes a snapshot of the maven repository and all projects we need to fetch the dependencies from and generates fixed input derivations for all of them?

@mmilata
Copy link
Member Author

mmilata commented Apr 1, 2020

Gonna close this as I don't have the resources to improve the current state. Feel free to reuse.

@mmilata mmilata closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Awaiting requested review from Ekleog

@Radvendii Radvendii Awaiting requested review from Radvendii

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @Mic92