Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fcmaes: init at 0.9.5.7 #83787

Closed
wants to merge 1 commit into from

Conversation

juliendehos
Copy link
Contributor

Motivation for this change

Adds fcmaes.
Should also help packaging nevergrad #80424 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting, add a few comments on what you're doing. Reorder top-level pythonPackages declaration.

pkgs/development/python-modules/fcmaes/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@grahamc
Copy link
Member

grahamc commented Mar 30, 2020

@GrahamcOfBorg eval

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM
assuming it has tests

pkgs/development/python-modules/fcmaes/default.nix Outdated Show resolved Hide resolved
@juliendehos juliendehos force-pushed the fcmaes branch 2 times, most recently from 987e953 to c21fb88 Compare March 31, 2020 19:18
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg eval
@GrahamcOfBorg build python27Packages.fcmaes
@GrahamcOfBorg build python37Packages.fcmaes
@GrahamcOfBorg build python38Packages.fcmaes

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, not sure about this python38 test:

builder for '/nix/store/ibwj1z7kdvhbxw7s7mc6a6zhl2cnarp1-python3.8-fcmaes-0.9.5.7.drv' failed with exit code 1; last 10 log lines:
              if limit > ret.fun:
                  break

          assert(limit > ret.fun) # optimization target not reached
  >       assert(max_eval + popsize > ret.nfev) # too much function calls
  E       assert (100000 + 1000) > 101000
  E        +  where 101000 =      fun: -959.640662720851\n    nfev: 101000\n     nit: 102\n  status: 0\n success: True\n       x: array([512.        , 404.23180511]).nfev

  fcmaes/test_cma.py:159: AssertionError
  ========================= 1 failed, 7 passed in 50.53s =========================
cannot build derivation '/nix/store/zfsh1jpm1qp76dqx89hx296jxnbal0bq-env.drv': 2 dependencies couldn't be built

@juliendehos
Copy link
Contributor Author

Closed since fcmaes has a new release, with new dependencies, and I don't want to maintain that.

@juliendehos juliendehos deleted the fcmaes branch September 1, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants