Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra-eval-jobs: Mirror eval errors in STDERR #729

Merged
merged 1 commit into from Mar 31, 2020
Merged

hydra-eval-jobs: Mirror eval errors in STDERR #729

merged 1 commit into from Mar 31, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Mar 30, 2020 •
edited

Otherwise, errors will not be shown to end-users, which makes debugging
long evals pretty much impossible.

Fixes #728

Note: I'm still testing this change, but want to make it public ASAP so I can be told what I did wrong (and why).

@samueldr
Copy link
Member Author

samueldr commented Mar 30, 2020 •
edited

This is what I was using to test the behaviour:

nixos/release-combined.nix

let
  pkgs = import <nixpkgs> {
    overlays = [(final: super: {
      fail-me = final.callPackage ../test.nix {};
    })];
  };
in
  pkgs.releaseTools.aggregate {
    name = "repro";
    constituents = [
      pkgs.fail-me
    ];
  }

test.nix

{ runCommandNoCC }:

runCommandNoCC "fail-me" {} ''
  ${aaa}
''

@samueldr
hydra-eval-jobs: Mirror eval errors in STDERR
76299b9 
Otherwise, errors will not be shown to end-users, which makes debugging
long evals pretty much impossible.
@samueldr
Copy link
Member Author

image

With the latest push this works as expected.

@samueldr samueldr mentioned this pull request Mar 31, 2020
Closed
@edolstra edolstra merged commit 082dbdb into NixOS:master Mar 31, 2020
@samueldr samueldr deleted the fix/error-transmission branch March 31, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hydra-eval-jobs masking real errors
2 participants
@samueldr @edolstra