Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyrit: init at 2019-12-13 #83739

Merged
merged 1 commit into from Apr 13, 2020
Merged

pyrit: init at 2019-12-13 #83739

merged 1 commit into from Apr 13, 2020

Conversation

danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Mar 30, 2020 •
edited

Motivation for this change

This package is used by wifite2. I intend to update the wifite2 package after this and hcxdumptool are included in nixpkgs.

I've tested the opencl support works with nvidia by running pyrit benchmark, after setting use_OpenCL = true in ~/.pyrit/config.

CC @Lassulus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Lassulus
Lassulus approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, seems to work:

[nix-shell:~/.cache/nixpkgs-review/pr-83739]$ pyrit selftest
Failed to load Pyrit's OpenCL-core ('Failed to enumerate OpenCL-platforms (Unknown CLresult)').
Pyrit 0.5.1 (C) 2008-2011 Lukas Lueg - 2015 John Mora
https://github.com/JPaulMora/Pyrit
This code is distributed under the GNU General Public License v3+

Cores incorporated in the test:
CPUs:
#1:  'CPU-Core (SSE2/AES)'
#2:  'CPU-Core (SSE2/AES)'
#3:  'CPU-Core (SSE2/AES)'
#4:  'CPU-Core (SSE2/AES)'
GPUs:

Running selftest...

All results verified. Your installation seems OK

@Lassulus Lassulus merged commit ca7be74 into NixOS:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @Lassulus