Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hcxdumptool: init at 6.0.5 #83738

Merged
merged 1 commit into from Apr 14, 2020
Merged

hcxdumptool: init at 6.0.5 #83738

merged 1 commit into from Apr 14, 2020

Conversation

danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Mar 30, 2020 •
edited

Motivation for this change

This package is used by wifite2. I intend to update the wifite2 package after this and pyrit are included in nixpkgs.

CC @dywedir @Lassulus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer danielfullmer changed the title hcxdumptool: init at 6.0.3 hcxdumptool: init at 6.0.5 Apr 11, 2020
Lassulus
Lassulus approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work

@Lassulus Lassulus merged commit 1c951b1 into NixOS:master Apr 14, 2020
@danielfullmer
Copy link
Contributor Author

@Lassulus Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @Lassulus