Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: 1.3.9 → 1.4.0 #83755

Merged
merged 2 commits into from Apr 18, 2020
Merged

fwupd: 1.3.9 → 1.4.0 #83755

merged 2 commits into from Apr 18, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 30, 2020 •
edited

Motivation for this change

jcat
Will be needed by fwupd in the future

https://blogs.gnome.org/hughsie/2020/03/23/initial-release-of-jcat/

Installed tests fail at the moment: hughsie/libjcat#19

fwupd

https://github.com/fwupd/fwupd/releases/tag/1.4.0
fwupd/fwupd@a3d6ee0

Installed tests fail: fwupd/fwupd#2007

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar marked this pull request as ready for review April 1, 2020 09:18
@jtojnar jtojnar mentioned this pull request Apr 8, 2020
Closed
@jtojnar jtojnar changed the title libjcat: init at 0.1.0 fwupd: 1.3.9 → 1.4.0 Apr 16, 2020
@jtojnar jtojnar force-pushed the jcat-0.1 branch 3 times, most recently from 19fda65 to f50546a Compare April 16, 2020 18:38
@jtojnar jtojnar merged commit 09c4736 into NixOS:master Apr 18, 2020
@jtojnar jtojnar deleted the jcat-0.1 branch April 18, 2020 18:38
@jtojnar jtojnar mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtojnar