Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

litecli: 1.1.0 -> 1.3.2 #83786

Merged
merged 1 commit into from Apr 2, 2020
Merged

litecli: 1.1.0 -> 1.3.2 #83786

merged 1 commit into from Apr 2, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 30, 2020

ZHF: #80379

https://hydra.nixos.org/build/115529461

Fixed tests: The 1.3.2 release tarball is missing a csv file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Scriptkiddi March 30, 2020 16:21
@Scriptkiddi
Copy link
Contributor

lgtm

@srhb srhb merged commit ba47be3 into NixOS:master Apr 2, 2020
@srhb
Copy link
Contributor

srhb commented Apr 2, 2020

Unfortunately for ZHF, this does not appear to build with a naïve cherry-pick onto release-20.03. Want to have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scriptkiddi Scriptkiddi Awaiting requested review from Scriptkiddi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @Scriptkiddi @srhb