Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseaudio: Enable bluetooth support by default #83775

Merged
merged 1 commit into from Mar 30, 2020
Merged

pulseaudio: Enable bluetooth support by default #83775

merged 1 commit into from Mar 30, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Mar 30, 2020 •
edited

It only increases the closure size by 0.5M and users who do not set
the NixOS option hardware.pulseaudio.package = pkgs.pulseaudioFull;
will be stumped by their bluetooth audio not working.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lovek323 March 30, 2020 13:14
@adisbladis
pulseaudio: Enable bluetooth support by default
e41f3d9 
It only increases the closure size by 0.5M and users who do not set
the NixOS option `hardware.pulseaudio.package = pkgs.pulseaudioFull;`
will be stumped by their bluetooth audio not working.
@adisbladis adisbladis changed the base branch from staging to master March 30, 2020 13:36
@adisbladis
Copy link
Member Author

Surprisingly this didn't lead to a mass-rebuild because of the separation of pulseaudio and libpulseaudio. Redirecting to master.

@adisbladis adisbladis merged commit cdf24a3 into NixOS:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adisbladis