Skip to content

nghttp2: add python bindings as pythonPackages.nghttp2 #83795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

nghttp2: add python bindings as pythonPackages.nghttp2 #83795

merged 1 commit into from
Mar 31, 2020
+29 −5

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Mar 30, 2020

Motivation for this change

Make nghttp2's python bindings available. A side effect of some other work I'm doing.

It's tricky to enable in nghttp2's default build, however, because it needs to be usable by curl, and we get cyclical dependencies if we add python to its requirements. Having it available as a separate build is better than nothing, though.

Of course, there's a massive rebuild because of curl, hence this is targeted at staging and I haven't done a full rebuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@risicle
nghttp2: add python bindings as pythonPackages.nghttp2
959e924 
it's tricky to enable in nghttp2's default build, however, because it needs
to be usable by curl, a very core nix package, and we get cyclical
dependencies if we add python to its requirements. having it available as
a separate build is better than nothing, though.
@risicle risicle requested review from FRidh and jonringer as code owners March 30, 2020 17:45
@FRidh
Copy link
Member

FRidh commented Mar 30, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 8.has: package (new) This PR adds a new package labels Mar 30, 2020
@ofborg ofborg bot requested review from dotlambda and FRidh March 30, 2020 18:51
@timokau timokau merged commit aa304bb into NixOS:staging Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @FRidh @timokau