Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #83518 for 20.03 #83796

Merged
merged 6 commits into from Mar 30, 2020
Merged

Backport #83518 for 20.03 #83796

merged 6 commits into from Mar 30, 2020

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Mar 30, 2020 •
edited

Motivation for this change

Adds new versions, but doesn't change any existing versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout and others added 5 commits March 28, 2020 03:05
@cdepillabout @Ericson2314
python3Packages.tensorflow-estimator: 1.15.1 -> 2.1.0
9939bd6 
(cherry picked from commit c186f5e)
@andir @Ericson2314
pythonPackages.tensorflow-estimator_1_15_1: init at 1.15.1
6c7b2ac 
TF 1.15 still needs an older version of the tensorflow-estimator
package.

(cherry picked from commit c539f93)
@Ericson2314
bazel_0_29: init at 0.29.1
d4de62d 
Needed for Tensorflow 2.1
@timokau @Ericson2314
python.pkgs.tensorflow{,-bin,-estimator,-tensorboard}-2: Init at 2.1.0
a730888 
Major breaking change from 1.x, so treating keeping both versions for now.

(adapted from 33f11be)
(adapted from 9e8dea7)
@Ericson2314
tensorflow-estimator-1.x: Put back comment
cef0110
@Ericson2314 Ericson2314 merged commit 6ca72b6 into NixOS:release-20.03 Mar 30, 2020
@Ericson2314 Ericson2314 deleted the add-tensorflow-2 branch April 1, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@abbradar abbradar Awaiting requested review from abbradar

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @cdepillabout @andir @timokau